Attachment 104285 Details for Bug 236332 – Fix

[patch] Fix

patch.txt (text/plain), 1.82 KB, created by Dani Megert

on 2008-06-10 04:34:36 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dani Megert

Created: 2008-06-10 04:34:36 EDT

Size: 1.82 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.ui
>Index: ui/org/eclipse/jdt/internal/ui/javaeditor/breadcrumb/EditorBreadcrumb.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/breadcrumb/EditorBreadcrumb.java,v
>retrieving revision 1.26
>diff -u -r1.26 EditorBreadcrumb.java
>--- ui/org/eclipse/jdt/internal/ui/javaeditor/breadcrumb/EditorBreadcrumb.java	7 May 2008 08:49:50 -0000	1.26
>+++ ui/org/eclipse/jdt/internal/ui/javaeditor/breadcrumb/EditorBreadcrumb.java	10 Jun 2008 08:19:21 -0000
>@@ -10,6 +10,8 @@
>  *******************************************************************************/
> package org.eclipse.jdt.internal.ui.javaeditor.breadcrumb;
> 
>+import org.eclipse.core.runtime.Assert;
>+
> import org.eclipse.swt.SWT;
> import org.eclipse.swt.events.MenuDetectEvent;
> import org.eclipse.swt.events.MenuDetectListener;
>@@ -120,7 +122,7 @@
> 	protected abstract boolean open(Object element);
> 	
> 	/**
>-	 * Create an action group for the context menu shown for 
>+	 * Create an action group for the context menu shown for
> 	 * the selection of the given selection provider or <code>null</code>
> 	 * if no context menu should be shown.
> 	 * 
>@@ -188,9 +190,8 @@
> 	 * @see org.eclipse.jdt.internal.ui.javaeditor.IBreadcrumb#createContent(org.eclipse.swt.widgets.Composite)
> 	 */
> 	public Control createContent(Composite parent) {
>-		if (fComposite != null)
>-			new IllegalArgumentException("Content must only be created once."); //$NON-NLS-1$
>-		
>+		Assert.isTrue(fComposite == null, "Content must only be created once."); //$NON-NLS-1$
>+
> 		boolean rtl= (getTextEditor().getSite().getShell().getStyle() & SWT.RIGHT_TO_LEFT) != 0;
> 
> 		fComposite= new Composite(parent, rtl ? SWT.RIGHT_TO_LEFT : SWT.NONE);

Actions: View | Diff

Attachments on bug 236332: 104285