Download
Getting Started
Members
Projects
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
More
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
Toggle navigation
Bugzilla – Attachment 101508 Details for
Bug 233224
[formatter] Xdoclet tags looses @ on format
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
Log In
[x]
|
Terms of Use
|
Copyright Agent
[patch]
Proposed patch
v00.txt (text/plain), 3.12 KB, created by
Frederic Fusier
on 2008-05-22 10:27:29 EDT
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
Frederic Fusier
Created:
2008-05-22 10:27:29 EDT
Size:
3.12 KB
patch
obsolete
>### Eclipse Workspace Patch 1.0 >#P org.eclipse.jdt.core >Index: formatter/org/eclipse/jdt/internal/formatter/FormatterCommentParser.java >=================================================================== >RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/formatter/org/eclipse/jdt/internal/formatter/FormatterCommentParser.java,v >retrieving revision 1.12 >diff -u -r1.12 FormatterCommentParser.java >--- formatter/org/eclipse/jdt/internal/formatter/FormatterCommentParser.java 20 May 2008 13:12:46 -0000 1.12 >+++ formatter/org/eclipse/jdt/internal/formatter/FormatterCommentParser.java 22 May 2008 13:59:07 -0000 >@@ -176,7 +176,7 @@ > this.invalidTagName = true; > return null; > } >- this.tagSourceStart = this.scanner.getCurrentTokenStartPosition(); >+ this.tagSourceStart = previousPosition; > this.tagSourceEnd = this.scanner.getCurrentTokenEndPosition(); > char[] tagName = this.scanner.getCurrentIdentifierSource(); > return tagName; >#P org.eclipse.jdt.core.tests.model >Index: src/org/eclipse/jdt/core/tests/formatter/FormatterCommentsBugsTest.java >=================================================================== >RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/formatter/FormatterCommentsBugsTest.java,v >retrieving revision 1.5 >diff -u -r1.5 FormatterCommentsBugsTest.java >--- src/org/eclipse/jdt/core/tests/formatter/FormatterCommentsBugsTest.java 21 May 2008 14:17:44 -0000 1.5 >+++ src/org/eclipse/jdt/core/tests/formatter/FormatterCommentsBugsTest.java 22 May 2008 13:59:09 -0000 >@@ -188,4 +188,14 @@ > this.preferences.comment_line_length = 40; > formatUnit("bugs.b232466", "X02.java"); > } >+ >+/** >+ * @bug 233224: [formatter] References of inlined tags are still split in certain circumstances >+ * @test Ensure that doclet tags are preserved while formatting >+ * @see "https://bugs.eclipse.org/bugs/show_bug.cgi?id=233224" >+ */ >+public void testBug233224() throws JavaModelException { >+ this.preferences.comment_line_length = 40; >+ formatUnit("bugs.b233224", "X01.java"); >+} > } >Index: workspace/FormatterJavadoc/test/bugs/b233224/out/X01.java >=================================================================== >RCS file: workspace/FormatterJavadoc/test/bugs/b233224/out/X01.java >diff -N workspace/FormatterJavadoc/test/bugs/b233224/out/X01.java >--- /dev/null 1 Jan 1970 00:00:00 -0000 >+++ workspace/FormatterJavadoc/test/bugs/b233224/out/X01.java 1 Jan 1970 00:00:00 -0000 >@@ -0,0 +1,10 @@ >+public class X01 { >+ >+ /** >+ * @ejb:interface-method test format >+ * of doclet >+ * tags >+ */ >+ void foo() { >+ } >+} >Index: workspace/FormatterJavadoc/test/bugs/b233224/X01.java >=================================================================== >RCS file: workspace/FormatterJavadoc/test/bugs/b233224/X01.java >diff -N workspace/FormatterJavadoc/test/bugs/b233224/X01.java >--- /dev/null 1 Jan 1970 00:00:00 -0000 >+++ workspace/FormatterJavadoc/test/bugs/b233224/X01.java 1 Jan 1970 00:00:00 -0000 >@@ -0,0 +1,8 @@ >+public class X01 { >+ >+ /** >+ * @ejb:interface-method test format of doclet tags >+ */ >+ void foo() { >+ } >+}
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 233224
: 101508