Attachment 100806 Details for Bug 232685 – Fix for ScrollBar (setValues() and setEnabled() implementations)

[patch] Fix for ScrollBar (setValues() and setEnabled() implementations)

0005-ScrollBar-flashing-and-enablement-fix.patch (text/plain), 1.40 KB, created by Mikhail Kalugin

on 2008-05-18 03:17:26 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Mikhail Kalugin

Created: 2008-05-18 03:17:26 EDT

Size: 1.40 KB

patch

obsolete

>diff --git a/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/ScrollBar.java b/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/ScrollBar.java
>index f7f25f6..35df110 100755
>--- a/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/ScrollBar.java	
>+++ b/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/ScrollBar.java	
>@@ -471,15 +471,16 @@ public void setIncrement (int value) {
>  */
> public void setEnabled (boolean enabled) {
> 	checkWidget();
>-//	if (enabled) {
>-//		if ((state & DISABLED) == 0) return;
>-//		state &= ~DISABLED;
>-//		OS.EnableControl (handle);
>-//	} else {
>-//		if ((state & DISABLED) != 0) return;
>-//		state |= DISABLED;
>-//		OS.DisableControl (handle);
>-//	}
>+	if (enabled) {
>+		if ((state & DISABLED) == 0) return;
>+		state &= ~DISABLED;
>+		//OS.EnableControl (handle);
>+	} else {
>+		if ((state & DISABLED) != 0) return;
>+		state |= DISABLED;
>+		//OS.DisableControl (handle);
>+	}
>+	view.setEnabled(enabled);
> }
> 
> /**
>@@ -618,7 +619,9 @@ public void setValues (int selection, int minimum, int maximum, int thumb, int i
> 	if (thumb < 1) return;
> 	if (increment < 1) return;
> 	if (pageIncrement < 1) return;
>-	thumb = Math.min (thumb, maximum - minimum);
>+	this.thumb = thumb = Math.min (thumb, maximum - minimum);
>+	this.maximum = maximum;
>+	this.minimum = minimum;
> 	this.increment = increment;
> 	this.pageIncrement = pageIncrement;
> 	updateBar(selection, minimum, maximum, thumb);

Flags:

Silenio_Quarti: iplog+

Actions: View | Diff

Attachments on bug 232685: 100806