Attachment #136892 for bug #203065

View | Details | Raw Unified | Return to bug 203065
Collapse All | Expand All




Bundle-Vendor: %provider-name
Bundle-Localization: plugin
Export-Package: 
 org.eclipse.pde.internal.ui;x-friends:="org.eclipse.pde.ua.ui",
 org.eclipse.pde.internal.ui.build;x-internal:=true,
 org.eclipse.pde.internal.ui.commands;x-internal:=true,
 org.eclipse.pde.internal.ui.compare;x-internal:=true,

 org.eclipse.pde.internal.ui.correction.java;x-internal:=true,
 org.eclipse.pde.internal.ui.dialogs;x-internal:=true,
 org.eclipse.pde.internal.ui.editor;x-friends:="org.eclipse.pde.ds.ui,org.eclipse.pde.ua.ui",
 org.eclipse.pde.internal.ui.editor.actions;x-friends:="org.eclipse.pde.ua.ui",
 org.eclipse.pde.internal.ui.editor.build;x-internal:=true,
 org.eclipse.pde.internal.ui.editor.category;x-internal:=true,
 org.eclipse.pde.internal.ui.editor.contentassist;x-internal:=true,
 org.eclipse.pde.internal.ui.editor.contentassist.display;x-internal:=true,
 org.eclipse.pde.internal.ui.editor.context;x-friends:="org.eclipse.pde.ua.ui",
 org.eclipse.pde.internal.ui.editor.feature;x-internal:=true,
 org.eclipse.pde.internal.ui.editor.outline;x-internal:=true,
 org.eclipse.pde.internal.ui.editor.plugin;x-friends:="org.eclipse.pde.runtime,org.eclipse.pde.ua.ui",
 org.eclipse.pde.internal.ui.editor.plugin.rows;x-internal:=true,
 org.eclipse.pde.internal.ui.editor.product;x-internal:=true,
 org.eclipse.pde.internal.ui.editor.schema;x-internal:=true,

 org.eclipse.pde.internal.ui.elements;x-internal:=true,
 org.eclipse.pde.internal.ui.launcher;x-internal:=true,
 org.eclipse.pde.internal.ui.nls;x-internal:=true,
 org.eclipse.pde.internal.ui.parts;x-friends:="org.eclipse.pde.ua.ui",
 org.eclipse.pde.internal.ui.preferences;x-internal:=true,
 org.eclipse.pde.internal.ui.properties;x-internal:=true,
 org.eclipse.pde.internal.ui.refactoring;x-internal:=true,

 org.eclipse.pde.internal.ui.search.dependencies;x-internal:=true,
 org.eclipse.pde.internal.ui.search.dialogs;x-internal:=true,
 org.eclipse.pde.internal.ui.shared.target;x-internal:=true,
 org.eclipse.pde.internal.ui.util;x-friends:="org.eclipse.pde.ua.ui",
 org.eclipse.pde.internal.ui.views.dependencies;x-internal:=true,
 org.eclipse.pde.internal.ui.views.plugins;x-internal:=true,
 org.eclipse.pde.internal.ui.views.target;x-internal:=true,




import org.eclipse.core.resources.IFile;
import org.eclipse.core.resources.IResource;
import org.eclipse.core.runtime.IPath;
import org.eclipse.core.runtime.Path;
import org.eclipse.jface.action.*;
import org.eclipse.jface.dialogs.MessageDialog;
import org.eclipse.jface.viewers.*;
import org.eclipse.jface.window.Window;
import org.eclipse.pde.core.IModelChangedEvent;
import org.eclipse.pde.internal.core.text.IDocumentElementNode;
import org.eclipse.pde.internal.ua.core.ctxhelp.ICtxHelpConstants;

import org.eclipse.ui.PlatformUI;
import org.eclipse.ui.actions.ActionFactory;
import org.eclipse.ui.actions.ContributionItemFactory;
import org.eclipse.ui.dialogs.ListDialog;
import org.eclipse.ui.dialogs.PatternFilter;
import org.eclipse.ui.forms.widgets.FormToolkit;
import org.eclipse.ui.forms.widgets.Section;

import org.eclipse.ui.keys.IBindingService;

/**
 * Tree section for the context help editor. Displays the structure of the xml
 * file and adds actions allowing manipulation of the structure.
 * 
 * @since 3.4
 * @see CtxHelpEditor
 */

	private TreeViewer fTree;
	private FormFilteredTree fFilteredTree;

	/*
	 * The indices for each button attached to the Tree Viewer. This type of UI
	 * form does not permit direct access to each particular button. However,
	 * using these indices, one can perform any typical SWT operation on any
	 * button.
	 */
	private static final int F_BUTTON_ADD_CONTEXT = 0;
	private static final int F_BUTTON_ADD_TOPIC = 2;

	private static final int F_BUTTON_REMOVE = 5;
	private static final int F_BUTTON_UP = 6;
	private static final int F_BUTTON_DOWN = 7;
	private static final int F_BUTTON_BROKENLINK = 8;

	// When one of the move buttons is pressed, a flag is used to determine the
	// direction
	private static final int F_UP_FLAG = -1;
	private static final int F_DOWN_FLAG = 1;


	// The action for opening a link from the context menu
	private OpenLinkAction fOpenLinkAction;

	// Used to temporarily store the target of a drop operation
	// so that it does not have be be recalculated
	private CtxHelpObject fDropTargetParent;
	private CtxHelpObject fDropTargetSibling;

	/**
	 * If items are dragged and dropped within this tree, then this flag
	 * inhibits reselection on the removal (drag) action, thus ensuring that the
	 * selected objects are the ones that were dropped.
	 */
	private boolean fDragFromHere;

	/**
	 * Action that allows a linked file to be opened in the editor
	 * 
	 * @since 3.4
	 */
	class OpenLinkAction extends Action {

	}

	public CtxHelpTreeSection(PDEFormPage formPage, Composite parent) {
		super(formPage, parent, Section.DESCRIPTION, new String[] {
				CtxHelpMessages.CtxHelpTreeSection_1, null,
				CtxHelpMessages.CtxHelpTreeSection_2,
				CtxHelpMessages.CtxHelpTreeSection_3, null,
				CtxHelpMessages.CtxHelpTreeSection_4,
				CtxHelpMessages.CtxHelpTreeSection_5,
				CtxHelpMessages.CtxHelpTreeSection_6,
				CtxHelpMessages.CtxHelpTreeSection_24 });
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see
	 * org.eclipse.pde.internal.ui.editor.PDESection#createClient(org.eclipse
	 * .ui.forms.widgets.Section, org.eclipse.ui.forms.widgets.FormToolkit)
	 */
	protected void createClient(Section section, FormToolkit toolkit) {
		fModel = (CtxHelpModel) getPage().getModel();

		fAddContextAction = new CtxHelpAbstractAddAction() {
			public void run() {
				if (fParentObject != null) {
					CtxHelpContext context = fParentObject.getModel()
							.getFactory().createContext();
					String id = PDELabelUtility.generateName(getChildNames(),
							CtxHelpMessages.CtxHelpTreeSection_9);
					context.setID(id);
					addChild(context);
				}

		fAddTopicAction = new CtxHelpAbstractAddAction() {
			public void run() {
				if (fParentObject != null) {
					CtxHelpTopic topic = fParentObject.getModel().getFactory()
							.createTopic();
					String label = PDELabelUtility.generateName(
							getChildNames(),
							CtxHelpMessages.CtxHelpTreeSection_11);
					topic.setLabel(label);
					addChild(topic);
				}

		fAddCommandAction = new CtxHelpAbstractAddAction() {
			public void run() {
				if (fParentObject != null) {
					CtxHelpCommand command = fParentObject.getModel()
							.getFactory().createCommand();
					String label = PDELabelUtility.generateName(
							getChildNames(),
							CtxHelpMessages.CtxHelpTreeSection_13);
					command.setLabel(label);
					addChild(command);
				}

	}

	/**
	 * Adds a link (with hand cursor) for tree 'Collapse All' action, which
	 * collapses the tree down to the second level
	 * 
	 * @param section
	 *            The section that the toolbar will belong to
	 * @param toolkit
	 *            The toolkit that will be used to make the toolbar
	 */
	private void createSectionToolbar(Section section, FormToolkit toolkit) {
		ToolBarManager toolBarManager = new ToolBarManager(SWT.FLAT);
		ToolBar toolbar = toolBarManager.createControl(section);

		final Cursor handCursor = new Cursor(Display.getCurrent(),
				SWT.CURSOR_HAND);
		toolbar.setCursor(handCursor);
		// Cursor needs to be explicitly disposed
		toolbar.addDisposeListener(new DisposeListener() {

		});

		// Add collapse action to the tool bar
		toolBarManager.add(new CollapseAction(fTree,
				CtxHelpMessages.CtxHelpTreeSection_15, 1, fModel
						.getCtxHelpRoot()));
		toolBarManager.update(true);
		section.setTextClient(toolbar);
	}

	/**
	 * Create the tree widget that will contain the structure
	 * 
	 * @param container
	 *            The container of the tree widget
	 * @param toolkit
	 *            The toolkit used to create the tree
	 */
	private void createTree(Composite container, FormToolkit toolkit) {
		TreePart treePart = getTreePart();


		fTree = treePart.getTreeViewer();
		fTree.setContentProvider(new CtxHelpContentProvider());
		fTree.setLabelProvider(PDEUserAssistanceUIPlugin.getDefault()
				.getLabelProvider());

		PDEUserAssistanceUIPlugin.getDefault().getLabelProvider().connect(this);

		// Create listener for the outline view 'link with editor' toggle button
		fTree
				.addPostSelectionChangedListener(getPage().getPDEEditor().new PDEFormEditorChangeListener());
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see
	 * org.eclipse.pde.internal.ui.editor.TreeSection#createTreeViewer(org.eclipse
	 * .swt.widgets.Composite, int)
	 */
	protected TreeViewer createTreeViewer(Composite parent, int style) {
		fFilteredTree = new FormFilteredTree(parent, style, new PatternFilter());

		getTreePart().setButtonEnabled(F_BUTTON_REMOVE, false);
		getTreePart().setButtonEnabled(F_BUTTON_UP, false);
		getTreePart().setButtonEnabled(F_BUTTON_DOWN, false);
		getTreePart().setButtonEnabled(F_BUTTON_BROKENLINK, true);
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see org.eclipse.ui.forms.AbstractFormPart#setFormInput(java.lang.Object)
	 */
	public boolean setFormInput(Object object) {
		// This method allows the outline view to select items in the tree
		// (Invoked by org.eclipse.ui.forms.editor.IFormPage.selectReveal(Object
		// object))
		if (object instanceof CtxHelpObject) {
			fTree.setSelection(new StructuredSelection(object), true);


	}

	/**
	 * @param selection
	 *            the new selection for the tree section
	 */
	public void setSelection(ISelection selection) {
		fTree.setSelection(selection);

		fTree.setSelection(fTree.getSelection());
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see
	 * org.eclipse.pde.internal.ui.editor.TreeSection#selectionChanged(org.eclipse
	 * .jface.viewers.IStructuredSelection)
	 */
	protected void selectionChanged(IStructuredSelection selection) {
		getPage().getPDEEditor().setSelection(selection);

			return;
		}

		IStructuredSelection selection = (IStructuredSelection) fTree
				.getSelection();
		CtxHelpObject firstSelectedObject = (CtxHelpObject) selection
				.getFirstElement();

		// Add Context
		getTreePart().setButtonEnabled(F_BUTTON_ADD_CONTEXT, true);

		if (firstSelectedObject != null) {
			if (firstSelectedObject.canAddSibling(ICtxHelpConstants.TYPE_TOPIC)) {
				enableAdd = true;
			} else if (firstSelectedObject
					.canAddChild(ICtxHelpConstants.TYPE_TOPIC)) {
				enableAdd = true;
			}
		}

		// Add Command
		enableAdd = false;
		if (firstSelectedObject != null) {
			if (firstSelectedObject
					.canAddSibling(ICtxHelpConstants.TYPE_COMMAND)) {
				enableAdd = true;
			} else if (firstSelectedObject
					.canAddChild(ICtxHelpConstants.TYPE_COMMAND)) {
				enableAdd = true;
			}
		}
		getTreePart().setButtonEnabled(F_BUTTON_ADD_COMMAND, enableAdd);

		// Remove button
		getTreePart().setButtonEnabled(F_BUTTON_REMOVE,
				getRemovableObjectFromSelection(selection).size() > 0);

		// Up and Down buttons
		boolean canMoveUp = true;
		boolean canMoveDown = true;
		if (firstSelectedObject == null
				|| firstSelectedObject.getType() == ICtxHelpConstants.TYPE_ROOT
				|| firstSelectedObject.getType() == ICtxHelpConstants.TYPE_DESCRIPTION
				|| selection.size() > 1) {
			canMoveUp = false;
			canMoveDown = false;
		} else {

		getTreePart().setButtonEnabled(F_BUTTON_DOWN, canMoveDown);
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see
	 * org.eclipse.pde.internal.ui.editor.StructuredViewerSection#fillContextMenu
	 * (org.eclipse.jface.action.IMenuManager)
	 */
	protected void fillContextMenu(IMenuManager manager) {
		IStructuredSelection selection = (IStructuredSelection) fTree
				.getSelection();
		Object object = selection.getFirstElement();
		// Has to be null or a CtxHelpObject object
		CtxHelpObject firstSelectedObject = (CtxHelpObject) object;

		// Populate the "New" sub-menu
		if (firstSelectedObject != null) {
			MenuManager submenu = new MenuManager(
					CtxHelpMessages.CtxHelpTreeSection_16);
			boolean addMenu = false;
			if (updateAddContextActionWithSelection(firstSelectedObject)) {
				submenu.add(fAddContextAction);

		}

		// Add the open link and show in actions
		if (firstSelectedObject instanceof CtxHelpTopic
				&& ((CtxHelpTopic) firstSelectedObject).getLocation() != null) {
			fOpenLinkAction.setTarget((CtxHelpTopic) firstSelectedObject);
			manager.add(fOpenLinkAction);
			fillContextMenuShowInAction(manager);

		}

		// Add clipboard actions
		getPage().getPDEEditor().getContributor().contextMenuAboutToShow(
				manager);
		manager.add(new Separator());

		// Add remove action

	/**
	 * Creates and a new submenu in the given menu manager and adds actions to
	 * allow a linked file to be opened in various views.
	 * 
	 * @param manager
	 *            menu manager to add the submenu to
	 */
	private void fillContextMenuShowInAction(IMenuManager manager) {
		String showInLabel = CtxHelpMessages.CtxHelpTreeSection_17;

		// Add a label for the keybinding for Show In action, if one exists
		IBindingService bindingService = (IBindingService) PlatformUI
				.getWorkbench().getAdapter(IBindingService.class);
		if (bindingService != null) {
			String keyBinding = bindingService
					.getBestActiveBindingFormattedFor("org.eclipse.ui.navigate.showInQuickMenu"); //$NON-NLS-1$
			if (keyBinding != null) {
				showInLabel += '\t' + keyBinding;
			}
		}

		IMenuManager showInMenu = new MenuManager(showInLabel);
		showInMenu.add(ContributionItemFactory.VIEWS_SHOW_IN.create(getPage()
				.getSite().getWorkbenchWindow()));

		manager.add(showInMenu);
	}

	/**
	 * Updates the add context action if the action should be available for the
	 * selection. Updates enablement, parent object and target object. Returns
	 * true if the action should be available to the selection.
	 * 
	 * @param selectedObject
	 *            selected object
	 * @return true if the action should be available for the current selection,
	 *         false otherwise
	 */
	private boolean updateAddContextActionWithSelection(
			CtxHelpObject selectedObject) {
		if (selectedObject != null
				&& selectedObject.canAddSibling(ICtxHelpConstants.TYPE_CONTEXT)) {
			fAddContextAction.setParentObject(selectedObject.getParent());
			fAddContextAction.setTargetObject(selectedObject);
			fAddContextAction.setEnabled(fModel.isEditable());
			return true;
		} else if (selectedObject != null
				&& selectedObject.canAddChild(ICtxHelpConstants.TYPE_CONTEXT)) {
			fAddContextAction.setParentObject(selectedObject);
			fAddContextAction.setTargetObject(null);
			fAddContextAction.setEnabled(fModel.isEditable());
			return true;
		} else if (fModel.getCtxHelpRoot().canAddChild(
				ICtxHelpConstants.TYPE_CONTEXT)) {
			fAddContextAction.setParentObject(fModel.getCtxHelpRoot());
			fAddContextAction.setTargetObject(null);
			fAddContextAction.setEnabled(fModel.isEditable());

	}

	/**
	 * Updates the add topic action if the action should be available for the
	 * selection. Updates enablement, parent object and target object. Returns
	 * true if the action should be available to the selection.
	 * 
	 * @param selectedObject
	 *            selected object
	 * @return true if the action should be available for the current selection,
	 *         false otherwise
	 */
	private boolean updateAddTopicActionWithSelection(
			CtxHelpObject selectedObject) {
		if (selectedObject != null) {
			if (selectedObject.canAddSibling(ICtxHelpConstants.TYPE_TOPIC)) {
				fAddTopicAction.setParentObject(selectedObject.getParent());

	}

	/**
	 * Updates the add topic action if the action should be available for the
	 * selection. Updates enablement, parent object and target object. Returns
	 * true if the action should be available to the selection.
	 * 
	 * @param selectedObject
	 *            selected object
	 * @return true if the action should be available for the current selection,
	 *         false otherwise
	 */
	private boolean updateAddCommandActionWithSelection(
			CtxHelpObject selectedObject) {
		if (selectedObject != null) {
			if (selectedObject.canAddSibling(ICtxHelpConstants.TYPE_COMMAND)) {
				fAddCommandAction.setParentObject(selectedObject.getParent());
				fAddCommandAction.setTargetObject(selectedObject);
				fAddCommandAction.setEnabled(fModel.isEditable());
				return true;
			} else if (selectedObject
					.canAddChild(ICtxHelpConstants.TYPE_COMMAND)) {
				fAddCommandAction.setParentObject(selectedObject);
				fAddCommandAction.setTargetObject(null);
				fAddCommandAction.setEnabled(fModel.isEditable());

	}

	/**
	 * Updates the remove action if the action should be available for the
	 * selection. Updates enablement, parent object and target object. Returns
	 * true if the action should be available to the selection.
	 * 
	 * @param selectedObject
	 *            selected object
	 * @return true if the action should be available for the current selection,
	 *         false otherwise
	 */
	private boolean updateRemoveActionWithSelection(
			IStructuredSelection selection) {
		List objectsToRemove = getRemovableObjectFromSelection(selection);
		fRemoveObjectAction.setToRemove((CtxHelpObject[]) objectsToRemove
				.toArray(new CtxHelpObject[objectsToRemove.size()]));
		fRemoveObjectAction.setEnabled(fModel.isEditable());
		return objectsToRemove.size() > 0;
	}

	/**
	 * Returns a list of objects that is the subset of objects in the selection
	 * that can be removed.
	 * 
	 * @param selection
	 *            the selection
	 * @return list of {@link CtxHelpObject}s that can be removed, possibly
	 *         empty.
	 */
	private List getRemovableObjectFromSelection(IStructuredSelection selection) {
		List objectsToRemove = new ArrayList();
		for (Iterator iterator = selection.iterator(); iterator.hasNext();) {
			Object currentObject = iterator.next();
			if (currentObject instanceof CtxHelpObject
					&& ((CtxHelpObject) currentObject).canBeRemoved()) {
				objectsToRemove.add(currentObject);
			}
		}
		return objectsToRemove;
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see
	 * org.eclipse.pde.internal.ui.editor.PDESection#doGlobalAction(java.lang
	 * .String)
	 */
	public boolean doGlobalAction(String actionId) {
		boolean cutAction = actionId.equals(ActionFactory.CUT.getId());

		if (cutAction || actionId.equals(ActionFactory.DELETE.getId())) {
			updateRemoveActionWithSelection((IStructuredSelection) fTree
					.getSelection());
			fRemoveObjectAction.run();
			return !cutAction;
		}

		return false;
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see
	 * org.eclipse.pde.internal.ui.editor.StructuredViewerSection#canPaste(java
	 * .lang.Object, java.lang.Object[])
	 */
	protected boolean canPaste(Object targetObject, Object[] sourceObjects) {
		return canDropCopy(targetObject, sourceObjects,
				ViewerDropAdapter.LOCATION_ON);
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see
	 * org.eclipse.pde.internal.ui.editor.StructuredViewerSection#doPaste(java
	 * .lang.Object, java.lang.Object[])
	 */
	protected void doPaste(Object targetObject, Object[] sourceObjects) {
		doDropCopy(targetObject, sourceObjects, ViewerDropAdapter.LOCATION_ON);
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see
	 * org.eclipse.pde.internal.ui.editor.TreeSection#handleDoubleClick(org.
	 * eclipse.jface.viewers.IStructuredSelection)
	 */
	protected void handleDoubleClick(IStructuredSelection selection) {
		Object selected = selection.getFirstElement();


	/**
	 * Opens the file that is linked in the given topic.
	 * 
	 * @param topic
	 *            the topic containing a link to a file
	 */
	public void open(CtxHelpTopic topic) {
		IPath resourcePath = topic.getLocation();
		if (!isEditable() || resourcePath == null || resourcePath.isEmpty()) {
			MessageDialog.openWarning(PDEUserAssistanceUIPlugin
					.getActiveWorkbenchShell(),
					CtxHelpMessages.CtxHelpTreeSection_18,
					CtxHelpMessages.CtxHelpTreeSection_19);
			return;
		}

		IResource resource = fModel.getUnderlyingResource().getProject()
				.findMember(resourcePath);
		if (resource != null && resource instanceof IFile) {
			IPath path = resource.getFullPath();
			if (HelpEditorUtil.hasValidPageExtension(path)) {
				try {
					IDE.openEditor(PDEUserAssistanceUIPlugin.getActivePage(),
							(IFile) resource, true);
				} catch (PartInitException e) { // suppress exception
				}
			} else {
				MessageDialog.openWarning(PDEUserAssistanceUIPlugin
						.getActiveWorkbenchShell(),
						CtxHelpMessages.CtxHelpTreeSection_20,
						CtxHelpMessages.CtxHelpTreeSection_21);
			}
		} else {
			MessageDialog.openWarning(PDEUserAssistanceUIPlugin
					.getActiveWorkbenchShell(),
					CtxHelpMessages.CtxHelpTreeSection_22,
					CtxHelpMessages.CtxHelpTreeSection_23);
		}
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see
	 * org.eclipse.pde.internal.ui.editor.StructuredViewerSection#buttonSelected
	 * (int)
	 */
	protected void buttonSelected(int index) {
		IStructuredSelection selection = (IStructuredSelection) fTree
				.getSelection();
		Object object = selection.getFirstElement();
		CtxHelpObject firstSelectedObject = (CtxHelpObject) object;
		switch (index) {
		case F_BUTTON_ADD_CONTEXT:
			updateAddContextActionWithSelection(firstSelectedObject);
			fAddContextAction.run();
			break;
		case F_BUTTON_ADD_TOPIC:
			updateAddTopicActionWithSelection(firstSelectedObject);
			fAddTopicAction.run();
			break;
		case F_BUTTON_ADD_COMMAND:
			updateAddCommandActionWithSelection(firstSelectedObject);
			fAddCommandAction.run();
			break;
		case F_BUTTON_REMOVE:
			updateRemoveActionWithSelection(selection);
			fRemoveObjectAction.run();
			break;
		case F_BUTTON_UP:
			handleMoveAction(F_UP_FLAG);
			break;
		case F_BUTTON_DOWN:
			handleMoveAction(F_DOWN_FLAG);
			break;
		case F_BUTTON_BROKENLINK:
			handleLinkButton();
		}
	}

	private void handleLinkButton() {
		ListDialog dialog = new ListDialog(PDEUserAssistanceUIPlugin
				.getActiveWorkbenchShell());
		dialog.setContentProvider(new IStructuredContentProvider() {

			public void inputChanged(Viewer viewer, Object oldInput,
					Object newInput) {
			}

			public void dispose() {

			}

			public Object[] getElements(Object inputElement) {
				return (Object[]) inputElement;
			}
		});

		dialog.setLabelProvider(new LabelProvider() {
			public String getText(Object element) {
				CtxHelpTopic topic = (CtxHelpTopic) element;
				return topic.getName();
			}
		});

		ArrayList links = new ArrayList();
		CtxHelpRoot root = fModel.getCtxHelpRoot();
		IDocumentElementNode[] contexts = root.getChildNodes();
		for (int i = 0; i < contexts.length; i++) {
			IDocumentElementNode context = contexts[i];
			IDocumentElementNode[] topics = context.getChildNodes();
			for (int j = 0; j < topics.length; j++) {
				IDocumentElementNode node = topics[j];
				if (node instanceof CtxHelpTopic) {
					CtxHelpTopic topic = (CtxHelpTopic) node;
					IPath location = topic.getLocation();
					if (!isEditable() || location == null || location.isEmpty()) {
						links.add(topic);
					} else {
						String path = location.toOSString();
						if (path.indexOf("#") > -1) {
							path = path.substring(0, path.indexOf("#"));
							location = Path.fromOSString(path);
						}
						IResource resource = fModel.getUnderlyingResource()
								.getProject().findMember(location);
						if (resource == null || !(resource instanceof IFile)) {
							links.add(topic);
						}
					}
				}
			}
		}
		dialog.setInput(links.toArray(new CtxHelpTopic[links.size()]));
		dialog.setMessage(CtxHelpMessages.CtxHelpTreeSection_25);
		dialog.setTitle(CtxHelpMessages.CtxHelpTreeSection_25);
		dialog.create();
		dialog.getOkButton().setText(CtxHelpMessages.CtxHelpTreeSection_26);
		if (Window.OK == dialog.open()) {
			CtxHelpTopic topic = (CtxHelpTopic) ((Object[]) dialog.getResult())[0];
			fTree.setSelection(new StructuredSelection(topic), true);
		}
	}

	/**
	 * Move an object within the structure.
	 * 
	 * @param positionFlag
	 *            The direction that the object will move, either F_UP_FLAG or
	 *            F_DOWN_FLAG
	 */
	private void handleMoveAction(int positionFlag) {
		IStructuredSelection sel = (IStructuredSelection) fTree.getSelection();

			CtxHelpObject parent = ctxHelpObject.getParent();
			if (parent != null) {
				parent.moveChild(ctxHelpObject, positionFlag);
				fTree
						.setSelection(new StructuredSelection(ctxHelpObject),
								true);
			}
		}

	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see org.eclipse.ui.forms.AbstractFormPart#refresh()
	 */
	public void refresh() {
		CtxHelpModel model = (CtxHelpModel) getPage().getModel();
		fTree.setInput(model);
		fTree.expandToLevel(2);
		fTree.setSelection(new StructuredSelection(model.getCtxHelpRoot()),
				true);
		getManagedForm().fireSelectionChanged(this, fTree.getSelection());
		super.refresh();
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see org.eclipse.ui.forms.AbstractFormPart#dispose()
	 */
	public void dispose() {
		PDEUserAssistanceUIPlugin.getDefault().getLabelProvider().disconnect(
				this);
		super.dispose();
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @seeorg.eclipse.pde.internal.ui.editor.StructuredViewerSection#
	 * isDragAndDropEnabled()
	 */
	protected boolean isDragAndDropEnabled() {
		return true;
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @seeorg.eclipse.pde.internal.ui.editor.StructuredViewerSection#
	 * getSupportedDNDOperations()
	 */
	public int getSupportedDNDOperations() {
		return DND.DROP_MOVE | DND.DROP_COPY;
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see
	 * org.eclipse.pde.internal.ui.editor.StructuredViewerSection#doDropCopy
	 * (java.lang.Object, java.lang.Object[], int)
	 */
	public void doDropCopy(Object targetObject, Object[] sourceObjects,
			int targetLocation) {
		if (fDropTargetParent != null) {
			if (fDropTargetSibling != null) {
				if (targetLocation == ViewerDropAdapter.LOCATION_BEFORE) {
					for (int i = 0; i < sourceObjects.length; i++) {
						((CtxHelpObject) sourceObjects[i]).reconnect(
								fDropTargetParent, fModel);
						fDropTargetParent.addChild(
								(CtxHelpObject) sourceObjects[i],
								fDropTargetSibling, true);
					}
				} else {
					for (int i = sourceObjects.length - 1; i >= 0; i--) {
						((CtxHelpObject) sourceObjects[i]).reconnect(
								fDropTargetParent, fModel);
						fDropTargetParent.addChild(
								(CtxHelpObject) sourceObjects[i],
								fDropTargetSibling, false);
					}
				}
			} else {
				for (int i = 0; i < sourceObjects.length; i++) {
					((CtxHelpObject) sourceObjects[i]).reconnect(
							fDropTargetParent, fModel);
					fDropTargetParent
							.addChild((CtxHelpObject) sourceObjects[i]);
				}
			}
		}

		fDropTargetSibling = null;
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see
	 * org.eclipse.pde.internal.ui.editor.StructuredViewerSection#doDropMove
	 * (java.lang.Object, java.lang.Object[], int)
	 */
	public void doDropMove(Object targetObject, Object[] sourceObjects,
			int targetLocation) {
		doDropCopy(targetObject, sourceObjects, targetLocation);
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see
	 * org.eclipse.pde.internal.ui.editor.StructuredViewerSection#canDropCopy
	 * (java.lang.Object, java.lang.Object[], int)
	 */
	public boolean canDropCopy(Object targetObject, Object[] sourceObjects,
			int targetLocation) {
		// Add as a child of the root
		if (targetObject == null
				|| !(targetObject instanceof CtxHelpObject || ((CtxHelpObject) targetObject)
						.getType() == ICtxHelpConstants.TYPE_ROOT)) {
			for (int i = 0; i < sourceObjects.length; i++) {
				if (!(sourceObjects[i] instanceof CtxHelpObject)
						|| !fModel.getCtxHelpRoot().canAddChild(
								((CtxHelpObject) sourceObjects[i]).getType())) {
					return false;
				}
			}

		if (targetLocation == ViewerDropAdapter.LOCATION_ON) {
			boolean result = true;
			for (int i = 0; i < sourceObjects.length; i++) {
				if (!(sourceObjects[i] instanceof CtxHelpObject)
						|| !dropTarget
								.canAddChild(((CtxHelpObject) sourceObjects[i])
										.getType())) {
					result = false;
					break;
				}


		// Add as a sibling of the target
		for (int i = 0; i < sourceObjects.length; i++) {
			if (!(sourceObjects[i] instanceof CtxHelpObject)
					|| !dropTarget
							.canAddSibling(((CtxHelpObject) sourceObjects[i])
									.getType())) {
				return false;
			}
		}

		return true;
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see
	 * org.eclipse.pde.internal.ui.editor.StructuredViewerSection#canDropMove
	 * (java.lang.Object, java.lang.Object[], int)
	 */
	public boolean canDropMove(Object targetObject, Object[] sourceObjects,
			int targetLocation) {
		// Same as drop copy operation
		return canDropCopy(targetObject, sourceObjects, targetLocation);
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see
	 * org.eclipse.pde.internal.ui.editor.StructuredViewerSection#canDragCopy
	 * (java.lang.Object[])
	 */
	public boolean canDragCopy(Object[] sourceObjects) {
		// Allow anything to be drag copied
		return true;
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see
	 * org.eclipse.pde.internal.ui.editor.StructuredViewerSection#canDragMove
	 * (java.lang.Object[])
	 */
	public boolean canDragMove(Object[] sourceObjects) {
		for (int i = 0; i < sourceObjects.length; i++) {
			if (!(sourceObjects[i] instanceof CtxHelpObject)
					|| !((CtxHelpObject) sourceObjects[i]).canBeRemoved()) {
				return false;
			}
		}

		return true;
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see
	 * org.eclipse.pde.internal.ui.editor.StructuredViewerSection#doDragRemove
	 * (java.lang.Object[])
	 */
	public void doDragRemove(Object[] sourceObjects) {
		updateRemoveActionWithSelection(new StructuredSelection(sourceObjects));

		fDragFromHere = false;
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see
	 * org.eclipse.pde.internal.ui.editor.PDESection#modelChanged(org.eclipse
	 * .pde.core.IModelChangedEvent)
	 */
	public void modelChanged(IModelChangedEvent event) {
		// No need to call super, world changed event handled here

			handleModelInsertType(event);
		} else if (event.getChangeType() == IModelChangedEvent.REMOVE) {
			handleModelRemoveType(event);
		} else if ((event.getChangeType() == IModelChangedEvent.CHANGE)
				&& (event.getChangedProperty()
						.equals(IDocumentElementNode.F_PROPERTY_CHANGE_TYPE_SWAP))) {
			handleModelChangeTypeSwap(event);
		} else if (event.getChangeType() == IModelChangedEvent.CHANGE) {
			handleModelChangeType(event);


	/**
	 * Handles the swap event
	 * 
	 * @param event
	 *            the swap event
	 */
	private void handleModelChangeTypeSwap(IModelChangedEvent event) {
		Object[] objects = event.getChangedObjects();


	/**
	 * The model is stale, refresh the UI
	 * 
	 * @param event
	 *            The world-change event
	 */
	private void handleModelEventWorldChanged(IModelChangedEvent event) {
		markStale();


	/**
	 * Handle insertions in the model
	 * 
	 * @param event
	 *            the insertion event
	 */
	private void handleModelInsertType(IModelChangedEvent event) {
		Object[] objects = event.getChangedObjects();

				CtxHelpObject object = (CtxHelpObject) objects[i];
				if (object.getType() != ICtxHelpConstants.TYPE_ROOT) {
					fTree.refresh(object.getParent());
					// Select the new object in the tree, unless it is a
					// description node
					if (!(object instanceof CtxHelpDescription)) {
						fTree.setSelection(new StructuredSelection(object),
								true);
					}
				}
			}


	/**
	 * Handle removals in the model
	 * 
	 * @param event
	 *            the removal event
	 */
	private void handleModelRemoveType(IModelChangedEvent event) {
		Object[] objects = event.getChangedObjects();

			if (objects[i] instanceof CtxHelpObject) {
				CtxHelpObject object = (CtxHelpObject) objects[i];
				fTree.remove(object);
				CtxHelpObject nextSelection = fRemoveObjectAction
						.getNextSelection();
				if (nextSelection != null) {
					fTree.refresh(object.getParent());
					if (!fDragFromHere) {
						fTree.setSelection(new StructuredSelection(
								nextSelection), true);
					}
					fRemoveObjectAction.clearNextSelection();
				}


	/**
	 * Handle an update to an object's properties
	 * 
	 * @param event
	 *            the update event
	 */
	private void handleModelChangeType(IModelChangedEvent event) {
		Object[] objects = event.getChangedObjects();

Lines 21-26 Link Here

(-)src/org/eclipse/pde/internal/ua/ui/editor/ctxhelp/messages.properties (+3 lines)
21	CtxHelpTreeSection_21=The selected file is not a valid HTML file.	21	CtxHelpTreeSection_21=The selected file is not a valid HTML file.
22	CtxHelpTreeSection_22=Open File	22	CtxHelpTreeSection_22=Open File
23	CtxHelpTreeSection_23=The specified file could not be found.	23	CtxHelpTreeSection_23=The specified file could not be found.
		24	CtxHelpTreeSection_24=Find Broken Links
		25	CtxHelpTreeSection_25=Broken Links
		26	CtxHelpTreeSection_26=Go to
24	CtxHelpTreeSection_3=Add Command	27	CtxHelpTreeSection_3=Add Command
25	CtxHelpTreeSection_4=Remove	28	CtxHelpTreeSection_4=Remove
26	CtxHelpTreeSection_5=Up	29	CtxHelpTreeSection_5=Up

Return to bug 203065

Lines 7-13 Link Here

(-)META-INF/MANIFEST.MF (-6 / +6 lines)
7	Bundle-Vendor: %provider-name	7	Bundle-Vendor: %provider-name
8	Bundle-Localization: plugin	8	Bundle-Localization: plugin
9	Export-Package:	9	Export-Package:
10	org.eclipse.pde.internal.ui;x-internal:=true,	10	org.eclipse.pde.internal.ui;x-friends:="org.eclipse.pde.ua.ui",
11	org.eclipse.pde.internal.ui.build;x-internal:=true,	11	org.eclipse.pde.internal.ui.build;x-internal:=true,
12	org.eclipse.pde.internal.ui.commands;x-internal:=true,	12	org.eclipse.pde.internal.ui.commands;x-internal:=true,
13	org.eclipse.pde.internal.ui.compare;x-internal:=true,	13	org.eclipse.pde.internal.ui.compare;x-internal:=true,
Lines 15-29 Link Here
15	org.eclipse.pde.internal.ui.correction.java;x-internal:=true,	15	org.eclipse.pde.internal.ui.correction.java;x-internal:=true,
16	org.eclipse.pde.internal.ui.dialogs;x-internal:=true,	16	org.eclipse.pde.internal.ui.dialogs;x-internal:=true,
17	org.eclipse.pde.internal.ui.editor;x-friends:="org.eclipse.pde.ds.ui,org.eclipse.pde.ua.ui",	17	org.eclipse.pde.internal.ui.editor;x-friends:="org.eclipse.pde.ds.ui,org.eclipse.pde.ua.ui",
18	org.eclipse.pde.internal.ui.editor.actions;x-internal:=true,	18	org.eclipse.pde.internal.ui.editor.actions;x-friends:="org.eclipse.pde.ua.ui",
19	org.eclipse.pde.internal.ui.editor.build;x-internal:=true,	19	org.eclipse.pde.internal.ui.editor.build;x-internal:=true,
20	org.eclipse.pde.internal.ui.editor.category;x-internal:=true,	20	org.eclipse.pde.internal.ui.editor.category;x-internal:=true,
21	org.eclipse.pde.internal.ui.editor.contentassist;x-internal:=true,	21	org.eclipse.pde.internal.ui.editor.contentassist;x-internal:=true,
22	org.eclipse.pde.internal.ui.editor.contentassist.display;x-internal:=true,	22	org.eclipse.pde.internal.ui.editor.contentassist.display;x-internal:=true,
23	org.eclipse.pde.internal.ui.editor.context;x-internal:=true,	23	org.eclipse.pde.internal.ui.editor.context;x-friends:="org.eclipse.pde.ua.ui",
24	org.eclipse.pde.internal.ui.editor.feature;x-internal:=true,	24	org.eclipse.pde.internal.ui.editor.feature;x-internal:=true,
25	org.eclipse.pde.internal.ui.editor.outline;x-internal:=true,	25	org.eclipse.pde.internal.ui.editor.outline;x-internal:=true,
26	org.eclipse.pde.internal.ui.editor.plugin;x-friends:="org.eclipse.pde.runtime",	26	org.eclipse.pde.internal.ui.editor.plugin;x-friends:="org.eclipse.pde.runtime,org.eclipse.pde.ua.ui",
27	org.eclipse.pde.internal.ui.editor.plugin.rows;x-internal:=true,	27	org.eclipse.pde.internal.ui.editor.plugin.rows;x-internal:=true,
28	org.eclipse.pde.internal.ui.editor.product;x-internal:=true,	28	org.eclipse.pde.internal.ui.editor.product;x-internal:=true,
29	org.eclipse.pde.internal.ui.editor.schema;x-internal:=true,	29	org.eclipse.pde.internal.ui.editor.schema;x-internal:=true,
Lines 34-40 Link Here
34	org.eclipse.pde.internal.ui.elements;x-internal:=true,	34	org.eclipse.pde.internal.ui.elements;x-internal:=true,
35	org.eclipse.pde.internal.ui.launcher;x-internal:=true,	35	org.eclipse.pde.internal.ui.launcher;x-internal:=true,
36	org.eclipse.pde.internal.ui.nls;x-internal:=true,	36	org.eclipse.pde.internal.ui.nls;x-internal:=true,
37	org.eclipse.pde.internal.ui.parts;x-internal:=true,	37	org.eclipse.pde.internal.ui.parts;x-friends:="org.eclipse.pde.ua.ui",
38	org.eclipse.pde.internal.ui.preferences;x-internal:=true,	38	org.eclipse.pde.internal.ui.preferences;x-internal:=true,
39	org.eclipse.pde.internal.ui.properties;x-internal:=true,	39	org.eclipse.pde.internal.ui.properties;x-internal:=true,
40	org.eclipse.pde.internal.ui.refactoring;x-internal:=true,	40	org.eclipse.pde.internal.ui.refactoring;x-internal:=true,
Lines 43-49 Link Here
43	org.eclipse.pde.internal.ui.search.dependencies;x-internal:=true,	43	org.eclipse.pde.internal.ui.search.dependencies;x-internal:=true,
44	org.eclipse.pde.internal.ui.search.dialogs;x-internal:=true,	44	org.eclipse.pde.internal.ui.search.dialogs;x-internal:=true,
45	org.eclipse.pde.internal.ui.shared.target;x-internal:=true,	45	org.eclipse.pde.internal.ui.shared.target;x-internal:=true,
46	org.eclipse.pde.internal.ui.util;x-internal:=true,	46	org.eclipse.pde.internal.ui.util;x-friends:="org.eclipse.pde.ua.ui",
47	org.eclipse.pde.internal.ui.views.dependencies;x-internal:=true,	47	org.eclipse.pde.internal.ui.views.dependencies;x-internal:=true,
48	org.eclipse.pde.internal.ui.views.plugins;x-internal:=true,	48	org.eclipse.pde.internal.ui.views.plugins;x-internal:=true,
49	org.eclipse.pde.internal.ui.views.target;x-internal:=true,	49	org.eclipse.pde.internal.ui.views.target;x-internal:=true,

Lines 14-20 Link Here

(-)src/org/eclipse/pde/internal/ua/ui/editor/ctxhelp/CtxHelpMessages.java (-1 / +4 lines)
14		14
15	public class CtxHelpMessages extends NLS {	15	public class CtxHelpMessages extends NLS {
16	private static final String BUNDLE_NAME = "org.eclipse.pde.internal.ua.ui.editor.ctxhelp.messages"; //$NON-NLS-1$	16	private static final String BUNDLE_NAME = "org.eclipse.pde.internal.ua.ui.editor.ctxhelp.messages"; //$NON-NLS-1$
17		17
18	public static String CtxHelpEditor_text;	18	public static String CtxHelpEditor_text;
19	public static String CtxHelpPage_errMsg;	19	public static String CtxHelpPage_errMsg;
20	public static String CtxHelpPage_errTitle;	20	public static String CtxHelpPage_errTitle;
Lines 38-43 Link Here
38	public static String CtxHelpTreeSection_21;	38	public static String CtxHelpTreeSection_21;
39	public static String CtxHelpTreeSection_22;	39	public static String CtxHelpTreeSection_22;
40	public static String CtxHelpTreeSection_23;	40	public static String CtxHelpTreeSection_23;
		41	public static String CtxHelpTreeSection_24;
		42	public static String CtxHelpTreeSection_25;
		43	public static String CtxHelpTreeSection_26;
41	public static String CtxHelpTreeSection_3;	44	public static String CtxHelpTreeSection_3;
42	public static String CtxHelpTreeSection_4;	45	public static String CtxHelpTreeSection_4;
43	public static String CtxHelpTreeSection_5;	46	public static String CtxHelpTreeSection_5;