View | Details | Raw Unified | Return to bug 272884 | Differences between
and this patch

Collapse All | Expand All

(-)Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java (-11 / +15 lines)
Lines 23-28 Link Here
23
import java.util.Set;
23
import java.util.Set;
24
import java.util.StringTokenizer;
24
import java.util.StringTokenizer;
25
25
26
import org.eclipse.osgi.util.NLS;
27
28
import org.eclipse.swt.SWT;
29
import org.eclipse.swt.custom.BusyIndicator;
30
import org.eclipse.swt.graphics.Rectangle;
31
import org.eclipse.swt.widgets.Composite;
32
import org.eclipse.swt.widgets.Control;
33
import org.eclipse.swt.widgets.Display;
34
import org.eclipse.swt.widgets.Shell;
35
26
import org.eclipse.core.runtime.Assert;
36
import org.eclipse.core.runtime.Assert;
27
import org.eclipse.core.runtime.IAdaptable;
37
import org.eclipse.core.runtime.IAdaptable;
28
import org.eclipse.core.runtime.IConfigurationElement;
38
import org.eclipse.core.runtime.IConfigurationElement;
Lines 37-42 Link Here
37
import org.eclipse.core.runtime.dynamichelpers.ExtensionTracker;
47
import org.eclipse.core.runtime.dynamichelpers.ExtensionTracker;
38
import org.eclipse.core.runtime.dynamichelpers.IExtensionChangeHandler;
48
import org.eclipse.core.runtime.dynamichelpers.IExtensionChangeHandler;
39
import org.eclipse.core.runtime.dynamichelpers.IExtensionTracker;
49
import org.eclipse.core.runtime.dynamichelpers.IExtensionTracker;
50
40
import org.eclipse.jface.dialogs.ErrorDialog;
51
import org.eclipse.jface.dialogs.ErrorDialog;
41
import org.eclipse.jface.dialogs.IDialogConstants;
52
import org.eclipse.jface.dialogs.IDialogConstants;
42
import org.eclipse.jface.dialogs.MessageDialog;
53
import org.eclipse.jface.dialogs.MessageDialog;
Lines 47-60 Link Here
47
import org.eclipse.jface.util.SafeRunnable;
58
import org.eclipse.jface.util.SafeRunnable;
48
import org.eclipse.jface.viewers.ISelection;
59
import org.eclipse.jface.viewers.ISelection;
49
import org.eclipse.jface.window.Window;
60
import org.eclipse.jface.window.Window;
50
import org.eclipse.osgi.util.NLS;
61
51
import org.eclipse.swt.SWT;
52
import org.eclipse.swt.custom.BusyIndicator;
53
import org.eclipse.swt.graphics.Rectangle;
54
import org.eclipse.swt.widgets.Composite;
55
import org.eclipse.swt.widgets.Control;
56
import org.eclipse.swt.widgets.Display;
57
import org.eclipse.swt.widgets.Shell;
58
import org.eclipse.ui.IActionBars;
62
import org.eclipse.ui.IActionBars;
59
import org.eclipse.ui.IEditorDescriptor;
63
import org.eclipse.ui.IEditorDescriptor;
60
import org.eclipse.ui.IEditorInput;
64
import org.eclipse.ui.IEditorInput;
Lines 5075-5085 Link Here
5075
						workbench.largeUpdateStart();
5079
						workbench.largeUpdateStart();
5076
						try {
5080
						try {
5077
							deferUpdates(true);
5081
							deferUpdates(true);
5078
							for (int i = inputs.length - 1; i >= 0; i--) {
5082
							for (int i = 0; i < inputs.length; i++) {
5079
							   if (inputs[i] == null || editorIDs[i] == null)
5083
							   if (inputs[i] == null || editorIDs[i] == null)
5080
							        throw new IllegalArgumentException();
5084
							        throw new IllegalArgumentException();
5081
								// activate the first editor
5085
								// activate the first editor
5082
								boolean activate = (i == 0);
5086
								boolean activate = (i == inputs.length - 1);
5083
								try {
5087
								try {
5084
									// check if there is an editor we can reuse
5088
									// check if there is an editor we can reuse
5085
							        IEditorReference ref = batchReuseEditor(inputs[i], editorIDs[i], 
5089
							        IEditorReference ref = batchReuseEditor(inputs[i], editorIDs[i], 
Lines 5095-5101 Link Here
5095
							deferUpdates(false);
5099
							deferUpdates(false);
5096
							// Update activation history. This can't be done
5100
							// Update activation history. This can't be done
5097
							// "as we go" or editors will be materialized.
5101
							// "as we go" or editors will be materialized.
5098
							for (int i = inputs.length - 1; i >= 0; i--) {
5102
							for (int i = 0; i < inputs.length; i++) {
5099
								if (results[i] == null)
5103
								if (results[i] == null)
5100
									continue;
5104
									continue;
5101
								activationList.bringToTop(results[i]);
5105
								activationList.bringToTop(results[i]);
(-)Eclipse UI/org/eclipse/ui/internal/presentations/util/PresentablePartFolder.java (-3 / +6 lines)
Lines 16-23 Link Here
16
import java.util.Iterator;
16
import java.util.Iterator;
17
import java.util.List;
17
import java.util.List;
18
18
19
import org.eclipse.core.runtime.Assert;
20
import org.eclipse.jface.util.Geometry;
21
import org.eclipse.swt.SWT;
19
import org.eclipse.swt.SWT;
22
import org.eclipse.swt.events.ControlEvent;
20
import org.eclipse.swt.events.ControlEvent;
23
import org.eclipse.swt.events.ControlListener;
21
import org.eclipse.swt.events.ControlListener;
Lines 30-35 Link Here
30
import org.eclipse.swt.graphics.Rectangle;
28
import org.eclipse.swt.graphics.Rectangle;
31
import org.eclipse.swt.widgets.Composite;
29
import org.eclipse.swt.widgets.Composite;
32
import org.eclipse.swt.widgets.Control;
30
import org.eclipse.swt.widgets.Control;
31
32
import org.eclipse.core.runtime.Assert;
33
34
import org.eclipse.jface.util.Geometry;
35
33
import org.eclipse.ui.IPropertyListener;
36
import org.eclipse.ui.IPropertyListener;
34
import org.eclipse.ui.internal.dnd.DragUtil;
37
import org.eclipse.ui.internal.dnd.DragUtil;
35
import org.eclipse.ui.internal.dnd.SwtUtil;
38
import org.eclipse.ui.internal.dnd.SwtUtil;
Lines 189-195 Link Here
189
        }
192
        }
190
        
193
        
191
        item = folder.add(idx, style);
194
        item = folder.add(idx, style);
192
195
		folder.setSelection(item);
193
        item.setData(part);
196
        item.setData(part);
194
197
195
        initTab(item, part);
198
        initTab(item, part);

Return to bug 272884